Add core nft view #103
Merged
Add core nft view #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinkline
reviewed
Jun 28, 2022
| /// NFTView is a group of views used to give a complete picture of an NFT | ||
| /// | ||
| pub struct NFTView { | ||
| pub let id: UInt64 |
There was a problem hiding this comment.
we might also want uuid in here
joshuahannan
approved these changes
Jul 7, 2022
Done |
joshuahannan
reviewed
Jul 8, 2022
| import ExampleNFT from "../../contracts/ExampleNFT.cdc" | ||
| import MetadataViews from "../../contracts/MetadataViews.cdc" | ||
|
|
||
| pub struct NFTView { |
There was a problem hiding this comment.
Is is necessary to define a new NFTView in here? Can't we just return the one from the view?
There was a problem hiding this comment.
You can't return some of the views, specifically CollectionData which contains a function type. Cadence throws an error if you try to return a function type from a script(i believe there is an issue to fix this but in the current state it would throw an error)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Issue: #98
Implementing the core NFT View which consists of common views that NFTs should implement to have basic interoperability throughout the ecosystem.